diff --git a/lib/ngtcp2_conn.c b/lib/ngtcp2_conn.c index d70d4dcf95118e8ea21d69686742a0676df11e8c..c7c5f30ac9481c571f4e4e95e8e26936b25eeb5c 100644 --- a/lib/ngtcp2_conn.c +++ b/lib/ngtcp2_conn.c @@ -8188,24 +8188,18 @@ static int conn_client_validate_transport_params(ngtcp2_conn *conn, const ngtcp2_transport_params *params) { if (!ngtcp2_cid_eq(&conn->rcid, ¶ms->original_dcid)) { - return NGTCP2_ERR_PROTO; + return NGTCP2_ERR_TRANSPORT_PARAM; } if (conn->flags & NGTCP2_CONN_FLAG_RECV_RETRY) { if (!params->retry_scid_present) { - /* draft explicitly specifies that this is - PROTOCOL_VIOLATION. */ - return NGTCP2_ERR_PROTO; + return NGTCP2_ERR_TRANSPORT_PARAM; } if (!ngtcp2_cid_eq(&conn->retry_scid, ¶ms->retry_scid)) { - /* draft explicitly specifies that this is - PROTOCOL_VIOLATION. */ - return NGTCP2_ERR_PROTO; + return NGTCP2_ERR_TRANSPORT_PARAM; } } else if (params->retry_scid_present) { - /* draft explicitly specifies that this is - PROTOCOL_VIOLATION. */ - return NGTCP2_ERR_PROTO; + return NGTCP2_ERR_TRANSPORT_PARAM; } if (params->preferred_address_present && @@ -8233,7 +8227,7 @@ int ngtcp2_conn_set_remote_transport_params( This requires that transport parameter must be fed into ngtcp2_conn as early as possible. */ if (!ngtcp2_cid_eq(&conn->dcid.current.cid, ¶ms->initial_scid)) { - return NGTCP2_ERR_PROTO; + return NGTCP2_ERR_TRANSPORT_PARAM; } if (!conn->server) { diff --git a/tests/ngtcp2_conn_test.c b/tests/ngtcp2_conn_test.c index 5218323ee87b5778d3d922f840c0012c8c152f85..b501cd1b4d7e3a2008bc0418799f25032eb3be4b 100644 --- a/tests/ngtcp2_conn_test.c +++ b/tests/ngtcp2_conn_test.c @@ -5164,7 +5164,7 @@ void test_ngtcp2_conn_set_remote_transport_params(void) { rv = ngtcp2_conn_set_remote_transport_params(conn, ¶ms); - CU_ASSERT(NGTCP2_ERR_PROTO == rv); + CU_ASSERT(NGTCP2_ERR_TRANSPORT_PARAM == rv); ngtcp2_conn_del(conn); @@ -5177,7 +5177,7 @@ void test_ngtcp2_conn_set_remote_transport_params(void) { rv = ngtcp2_conn_set_remote_transport_params(conn, ¶ms); - CU_ASSERT(NGTCP2_ERR_PROTO == rv); + CU_ASSERT(NGTCP2_ERR_TRANSPORT_PARAM == rv); ngtcp2_conn_del(conn); @@ -5192,7 +5192,7 @@ void test_ngtcp2_conn_set_remote_transport_params(void) { rv = ngtcp2_conn_set_remote_transport_params(conn, ¶ms); - CU_ASSERT(NGTCP2_ERR_PROTO == rv); + CU_ASSERT(NGTCP2_ERR_TRANSPORT_PARAM == rv); ngtcp2_conn_del(conn); @@ -5228,7 +5228,7 @@ void test_ngtcp2_conn_set_remote_transport_params(void) { rv = ngtcp2_conn_set_remote_transport_params(conn, ¶ms); - CU_ASSERT(NGTCP2_ERR_PROTO == rv); + CU_ASSERT(NGTCP2_ERR_TRANSPORT_PARAM == rv); ngtcp2_conn_del(conn); }