Skip to content
Snippets Groups Projects
  1. Nov 05, 2019
    • Amir Livneh's avatar
      Fix condition checking for Initial packet · b2268957
      Amir Livneh authored
      The code previously determined whether a packet was an Initial packet by looking at its type value, without first checking it was not a Version Negotiation packet. In the case of a Version Negotiation packet, reading the type value returned the random value in the Unused field. This occasionally caused Version Negotiation packets to be misinterpreted as Initial packets. When this happened, ngtcp2_conn_read_pkt() returned NGTCP2_ERR_DRAINING instead of NGTCP2_ERR_RECV_VERSION_NEGOTIATION.
      b2268957
  2. Nov 04, 2019
  3. Nov 02, 2019
  4. Nov 01, 2019
  5. Oct 31, 2019
  6. Oct 30, 2019
    • Daniel Bevenius's avatar
      Add default clause to switch statements · 39517705
      Daniel Bevenius authored
      When compiling with the flag -Wswitch-enum there are a number of
      warnings like the following:
      ngtcp2_conn.c:7960:11: warning:
      7 enumeration values not handled in switch:
        'NGTCP2_CS_CLIENT_INITIAL',
        'NGTCP2_CS_CLIENT_WAIT_HANDSHAKE',
        'NGTCP2_CS_CLIENT_TLS_HANDSHAKE_FAILED'... [-Wswitch]
        switch (conn->state) {
      
      This commit adds a default clause to avoid this as they are reported as
      errors on the CI server and failing the build.
      39517705
  7. Oct 29, 2019
    • Daniel Bevenius's avatar
      Use TLS_client_method and TLS_server_method · fc10f054
      Daniel Bevenius authored
      This commit changes the TLS_method() used by the client and server to
      use more specific TLS_client_method() and TLS_server_method().
      
      The main difference between these two are ossl_statem_accept is
      undefined for the client, and ossl_statem_connect is undefined for the
      server:
      
      IMPLEMENT_tls_meth_func(TLS_ANY_VERSION, 0, 0,
                              TLS_server_method,
                              ossl_statem_accept,
                              ssl_undefined_function, TLSv1_2_enc_data)
      
      IMPLEMENT_tls_meth_func(TLS_ANY_VERSION, 0, 0,
                              TLS_client_method,
                              ssl_undefined_function,
                              ossl_statem_connect, TLSv1_2_enc_data)
      
      ossl_statem_accept and ossl_statem_connect are defined like this:
      
      int ossl_statem_accept(SSL *s) {
          return state_machine(s, 1);
      }
      int ossl_statem_connect(SSL *s) {
          return state_machine(s, 0);
      }
      
      So they are both calling state_machine but with setting the server
      parameter to 1 and 0 (for...
      fc10f054
    • Tatsuhiro Tsujikawa's avatar
      Merge pull request #182 from danbev/move-template-header-server · 981b5db7
      Tatsuhiro Tsujikawa authored
      Move template.h into server.cc
      981b5db7
    • Tatsuhiro Tsujikawa's avatar
      Merge pull request #181 from danbev/wireshark-readme · 8fc06959
      Tatsuhiro Tsujikawa authored
      Add Wireshark configuration steps
      8fc06959
    • Daniel Bevenius's avatar
      Use ngtcp2_conn_state as type for state field · 3838c4e6
      Daniel Bevenius authored
      This commit suggests updating ngtcp2_conn's state field to be of type
      ngtcp2_conn_state instead of type int.
      3838c4e6
  8. Oct 28, 2019
  9. Oct 27, 2019